Add precompile interfaces for Multi-Constraint Pricer #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gligneul
reviewed
Oct 17, 2025
| function getPricesInArbGas() external view returns (uint256, uint256, uint256); | ||
|
|
||
| /// @notice Get the gas accounting parameters. `gasPoolMax` is always zero, as the exponential pricing model has no such notion. | ||
| /// @return (speedLimitPerSecond, gasPoolMax, maxBlockGasLimit) |
There was a problem hiding this comment.
What about the other two values gasPoolMax, maxBlockGasLimit, should we add methods for them?
There was a problem hiding this comment.
I assume that for the new model all these fields should be zeros. If confirmed, I'll update the comment
There was a problem hiding this comment.
See OffchainLabs/nitro#3860 (comment)
I think we should have another method that returns just the maxBlockGasLimit.
/// @notice Get the maxBlockGasLimit
/// @notice Available in ArbOS version 50 and above
function getMaxBlockGasLimit() external view returns (uint256);
MishkaRogachev
force-pushed
the
add-precompiles-for-multi-constraint-pricer
branch
from
7b1e927 to
96ed82d
Compare
gligneul
approved these changes
Oct 17, 2025
gligneul
requested changes
Oct 17, 2025
| function getPricesInArbGas() external view returns (uint256, uint256, uint256); | ||
|
|
||
| /// @notice Get the gas accounting parameters. `gasPoolMax` is always zero, as the exponential pricing model has no such notion. | ||
| /// @return (speedLimitPerSecond, gasPoolMax, maxBlockGasLimit) |
There was a problem hiding this comment.
See OffchainLabs/nitro#3860 (comment)
I think we should have another method that returns just the maxBlockGasLimit.
/// @notice Get the maxBlockGasLimit
/// @notice Available in ArbOS version 50 and above
function getMaxBlockGasLimit() external view returns (uint256);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of NIT-4021
Add Multi-Constraint Pricer methods:
getGasPricingConstraintstoArbGasInfoto fetch constraints as an array of triples (gas_target_per_second, time_constant_seconds, backlog)setGasPricingConstraintstoArbOwnerto set constraints as an array of pairs (gas target, time constraint)